trent/fcc-challenges
1
0
Fork 0
mirror of https://github.com/TrentSPalmer/fcc-challenges.git synced 2024-11-24 04:11:30 -08:00
Code Issues Projects Releases Wiki Activity

drum-machine fix esc key back navigation in selection menus

Browse Source
This commit is contained in:
Trent Palmer 2020-05-27 14:09:00 -07:00
parent fc53c8865c
commit e680fdc2c2
2 changed files with 15 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drum-machine/README.md
View File

@ -10,9 +10,8 @@
### TODOS ### TODOS
* increase granularity of esc key function in selection menus back navigation * fix toolstips for menuselectionitems
* add focus() to selectionMenuItems so that you can immediately begin scrolling with arrow keys * add focus() to selectionMenuItems so that you can immediately begin scrolling with arrow keys
* add tip for scrolling selectionMenuItems * add tip for scrolling selectionMenuItems
* make sure metronome continues on volume, sound, or metronome BPM change * make sure metronome continues on volume, sound, or metronome BPM change
* add additional metronome speed values * add additional metronome speed values
* fix toolstips for menuselectionitems

18
drum-machine/makeSelection.js
View File

@ -48,8 +48,13 @@ const makeMetronomeSelection = (selection) => {
makeAudioControl(padSelectingFor); makeAudioControl(padSelectingFor);
makeMetronomeIcons(padSelectingFor); makeMetronomeIcons(padSelectingFor);
} else if (selection === '( cancel -- back )') { } else if (selection === '( cancel -- back )') {
metronomeMenuDisplayed = false; if (padSelectingFor === '') {
$('#display-middle-left-b').html((drumPadGrid)); metronomeMenuDisplayed = false;
$('#display-middle-left-b').html((drumPadGrid));
} else {
padSelectingFor = '';
showKeyMetronomeSelectionMenu();
}
} }
}; };
@ -112,8 +117,13 @@ const makeVolumeSelection = (selection) => {
volumeMenuDisplayed = false; volumeMenuDisplayed = false;
$('#display-middle-left-b').html((drumPadGrid)); $('#display-middle-left-b').html((drumPadGrid));
} else if (selection === '( cancel -- back )') { } else if (selection === '( cancel -- back )') {
volumeMenuDisplayed = false; if (padSelectingFor === '') {
$('#display-middle-left-b').html((drumPadGrid)); volumeMenuDisplayed = false;
$('#display-middle-left-b').html((drumPadGrid));
} else {
padSelectingFor = '';
showKeyVolumeSelectionMenu();
}
} }
}; };